Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Vis Builder] global data persistence for vis builder #3042

Merged
merged 1 commit into from
Jan 3, 2023
Merged

[Backport 2.x] [Vis Builder] global data persistence for vis builder #3042

merged 1 commit into from
Jan 3, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9646d02 from #2896.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 7, 2022 19:17
@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Dec 7, 2022
@abbyhu2000
Copy link
Member

Added skip changlog because it seems like after resolving changelog conflict in the originated PR and merging main into the originating PR, the changelog change is not included here anymore.

@codecov-commenter
Copy link

Codecov Report

Merging #3042 (9646d02) into 2.x (0a92e60) will decrease coverage by 0.02%.
The diff coverage is 64.48%.

❗ Current head 9646d02 differs from pull request most recent head 3e0b6aa. Consider uploading reports for the commit 3e0b6aa to get more accurate results

@@            Coverage Diff             @@
##              2.x    #3042      +/-   ##
==========================================
- Coverage   66.67%   66.64%   -0.03%     
==========================================
  Files        3219     3219              
  Lines       61450    61477      +27     
  Branches     9417     9418       +1     
==========================================
+ Hits        40971    40974       +3     
- Misses      18232    18257      +25     
+ Partials     2247     2246       -1
Flag Coverage Δ
Linux 66.64% <64.48%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...-opensearch-archiver/src/lib/indices/test_stubs.ts 80.00% <ø> (ø)
...ed_tests_reporter/run_failed_tests_reporter_cli.ts 17.91% <0.00%> (ø)
...tional_test_runner/lib/config/fixtures/config.1.js 100.00% <ø> (ø)
...tional_test_runner/lib/config/fixtures/config.2.js 100.00% <ø> (ø)
..._test_runner/lib/config/fixtures/config.invalid.js 100.00% <ø> (ø)
packages/osd-utils/src/package_json/index.ts 100.00% <ø> (ø)
packages/osd-utils/src/path/index.ts 75.00% <ø> (ø)
src/cli/cluster/cluster_manager.ts 43.68% <ø> (ø)
src/cli_plugin/install/settings.js 100.00% <ø> (ø)
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added autocut Skip the changelog verification check on backports and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 9, 2022
@joshuarrrr
Copy link
Member

For auto-backports, instead of Skip-Changelog, use autocut. They do the same thing for now, but eventually they won't.

@abbyhu2000
Copy link
Member

For auto-backports, instead of Skip-Changelog, use autocut. They do the same thing for now, but eventually they won't.

Thanks Josh, that's good to know.

@ashwin-pc
Copy link
Member

@AMoo-Miki the windows tests are always failing here when trying to build plugins. Do you know what might be the issue?

@joshuarrrr
Copy link
Member

@ashwin-pc I wonder if we missed a backport to 2.x... I'm pretty sure all the windows-related PRs were backported, but we should double check.

@joshuarrrr joshuarrrr added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 23, 2022
@github-actions @joshuarrrr
[Vis Builder] Add global data persistence for vis builder (#2896)
693d003 
* Add global data persistence for vis builder

Persist filters, time range, time refresh interval for vis builder when we
refresh or navigate to other apps such as dashboard, discover, timeline and visualize

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 9646d02)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@joshuarrrr joshuarrrr force-pushed the backport/backport-2896-to-2.x branch from 3e0b6aa to 693d003 Compare December 28, 2022 21:21
@abbyhu2000 abbyhu2000 merged commit ea36d5a into 2.x Jan 3, 2023
@github-actions github-actions bot deleted the backport/backport-2896-to-2.x branch January 3, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abbyhu2000 @codecov-commenter @joshuarrrr @ashwin-pc @kavilla